Fix language server crash. (shader-slang#5395)

jkwak-work · Oct 24, 2024 · ee709cf · ee709cf
1 parent 61aa670
commit ee709cf
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 0 deletions.
diff --git a/source/slang/slang-check-decl.cpp b/source/slang/slang-check-decl.cpp
@@ -7861,6 +7861,13 @@ namespace Slang
                 if (semantics)
                     semantics->ensureDecl(genericTypeConstraintDecl, DeclCheckState::ReadyForReference);
                 auto constraintDeclRef = astBuilder->getDirectDeclRef<GenericTypeConstraintDecl>(genericTypeConstraintDecl);
+                auto supType = getSup(astBuilder, constraintDeclRef);
+                if (!supType)
+                {
+                    args.add(astBuilder->getErrorType());
+                    shouldCache = false;
+                    continue;
+                }
                 auto witness =
                     astBuilder->getDeclaredSubtypeWitness(
                         getSub(astBuilder, constraintDeclRef),

diff --git a/tests/language-server/robustness-8.slang b/tests/language-server/robustness-8.slang
@@ -0,0 +1,8 @@
+//TEST:LANG_SERVER(filecheck=CHECK):
+//
+__generic < T : struct> extension T
+{
+// CHECK: null
+//HOVER:7,32
+    __init(StructuredBuffer<T>) {}
+}