Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General enhancements #12

Open
19 tasks done
sSwerk opened this issue Feb 1, 2022 · 11 comments
Open
19 tasks done

General enhancements #12

sSwerk opened this issue Feb 1, 2022 · 11 comments
Assignees
Labels
enhancement New feature or request medium prio

Comments

@sSwerk
Copy link
Member

sSwerk commented Feb 1, 2022

Transfer from Google Drive

  • Write short how to put a paper on the group website tutorial
  • Write short how to create your own personal page on the group website tutorial
  • Paper MD Template
  • Personal Page MD Template
  • Broken link checker (see Add automatic broken link checking #9 , Htmlproofer Github Action #10 )
  • Make background of favicon transparent (didn’t notice^^)

Transfer from Slack

  • We could use Montserrat (https://fonts.google.com/specimen/Montserrat?query=Mont) for the headings (either Bold or Semi Bold), maybe also for the body text (Light or Regular).
  • add team on publication page?
  • headings on some pages not aligned with content
  • font for 'Invited Lab Talks' and 'Student Projects' should be the same as other headings on homepage.
  • replace drop shadow with single px border?
  • style of submenu on personal pages -> other button style and alignment?
  • change underline style to solid

Notes by Marc

  • global menu seems sticks at the top - should be further down (see design by Andreas)
  • on personal pages (e.g. Marc) h1 looks very different to h2. there should be a clear difference
  • personal page marc: something is wrong with the heading spacing
  • collaborator logos can be a bit smaller (vrvis, university of utah, etc.)
  • team pictures can be a bit bigger
  • reduce height of 'More publications' button to half?
@sSwerk sSwerk self-assigned this Feb 1, 2022
@sSwerk sSwerk added the enhancement New feature or request label Feb 1, 2022
@mstreit
Copy link
Collaborator

mstreit commented Apr 15, 2022

thanks for the changes so far:
what I consider as still important in terms of changes (in addition to the remaining ones from above):

  • global menu seems sticks at the top - should be further down (see design by Andreas)
  • on personal pages (e.g. Marc) h1 looks very different to h2. there should be a clear difference
  • personal page marc: something is wrong with the heading spacing

image

- collaborator logos can be a bit smaller (vrvis, university of utah, etc.) - team pictures can be a bit bigger - reduce height of 'More publications' button to half? thanks!

sSwerk added a commit that referenced this issue Apr 15, 2022
sSwerk added a commit that referenced this issue Apr 15, 2022
sSwerk added a commit that referenced this issue Apr 15, 2022
sSwerk added a commit that referenced this issue Apr 15, 2022
@sSwerk
Copy link
Member Author

sSwerk commented Apr 15, 2022

thanks for the changes so far: what I consider as still important in terms of changes (in addition to the remaining ones from above):

* global menu seems sticks at the top - should be further down (see design by Andreas)

* on personal pages (e.g. Marc) h1 looks very different to h2. there should be a clear difference

* personal page marc: something is wrong with the heading spacing
image - collaborator logos can be a bit smaller (vrvis, university of utah, etc.) - team pictures can be a bit bigger - reduce height of 'More publications' button to half? thanks!

I tried to fix several issues with my commits today - is it ok like this or do you want further changes regarding your notes?

sSwerk added a commit that referenced this issue Apr 19, 2022
@sSwerk
Copy link
Member Author

sSwerk commented Apr 19, 2022

I changed the heading font to Montserrat (commit 705046f), should we also change the font for the body text?

@sSwerk
Copy link
Member Author

sSwerk commented Apr 19, 2022

regarding "headings on some pages not aligned with content", on which pages is this the case?

@sSwerk
Copy link
Member Author

sSwerk commented Apr 19, 2022

regarding " replace drop shadow with single px border?", where should this be implemented?

@mstreit
Copy link
Collaborator

mstreit commented Apr 21, 2022

I changed the heading font to Montserrat (commit 705046f), should we also change the font for the body text?

should be the same as in Andreas design.

@mstreit
Copy link
Collaborator

mstreit commented Apr 21, 2022

regarding "headings on some pages not aligned with content", on which pages is this the case?

on the publication page and on my personal page, for instance.
image

@mstreit
Copy link
Collaborator

mstreit commented Apr 21, 2022

regarding " replace drop shadow with single px border?", where should this be implemented?

for all paper preview images. but I am not sure what looks better. what's your opinion? how is it in Andreas' design?

@sSwerk
Copy link
Member Author

sSwerk commented Apr 21, 2022

regarding " replace drop shadow with single px border?", where should this be implemented?

for all paper preview images. but I am not sure what looks better. what's your opinion? how is it in Andreas' design?

If you mean "https://drive.google.com/drive/u/0/folders/10au1izr4rARUfXJXYMJFHp_BmWcJteuI" by Andreas' design, it is like this:
image

and currently this one is live:
image

I cannot see a difference

@mstreit
Copy link
Collaborator

mstreit commented Apr 21, 2022

Ok, then let's leave it as is.

sSwerk added a commit that referenced this issue May 3, 2022
@sSwerk
Copy link
Member Author

sSwerk commented May 3, 2022

regarding "headings on some pages not aligned with content", on which pages is this the case?

on the publication page and on my personal page, for instance. image

Should be fixed with commit f8b19cc

sSwerk added a commit that referenced this issue Jul 20, 2022
sSwerk added a commit that referenced this issue Jul 20, 2022
sSwerk added a commit that referenced this issue Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request medium prio
Projects
None yet
Development

No branches or pull requests

2 participants