Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group position when building up a traversal is not correct #132

Open
VanessaFediuk opened this issue Oct 16, 2023 · 1 comment
Open

Group position when building up a traversal is not correct #132

VanessaFediuk opened this issue Oct 16, 2023 · 1 comment
Assignees

Comments

@VanessaFediuk
Copy link
Collaborator

VanessaFediuk commented Oct 16, 2023

When a Story is built up in the editor(when selecting a traversal strategy from the drop-down or when building the initial traversal when opening the editor) the position of the group nodes and of the nodes inside of a group are not correct. The screenshot shows that for the depth-first traversal. Seems like the position of groups and nodes inside of groups is handled like the groups would be a default node. Child nodes are positioned on top of each other(they are all there but only one can be seen on the screenshot). The edge is not connected with the Group node but to one of its children.

Image

This was working before the new saving method was used. Now the following useEffect function is called before the changes the buildTraversal function was called. parts of the build Traversal might help to make this work.
useEffect(() => {
props.setNodesForSave(nodes);
props.setEdgesForSave(edges);
const tOrder = new TraversalOrder(edges, nodes);
tOrder.createTraversal();
}, [nodes, props, edges]);

@VanessaFediuk VanessaFediuk converted this from a draft issue Oct 16, 2023
@VanessaFediuk
Copy link
Collaborator Author

Position of nodes is fixed. Edges need to be handled next.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Author Side
Development

No branches or pull requests

2 participants