Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature request: Support folding in JSX scope #13

Open
koenpunt opened this issue Aug 17, 2016 · 2 comments
Open

Feature request: Support folding in JSX scope #13

koenpunt opened this issue Aug 17, 2016 · 2 comments

Comments

@koenpunt
Copy link
Contributor

Now when folding inside a JSX scope, the parent JS scope folds instead of the JSX tags.

Not sure if this is even possible with an injection grammar(?)
koenpunt added a commit to koenpunt/javascript-jsx.tmbundle that referenced this issue Aug 17, 2016
@koenpunt
Support folding of tags in jsx-content
52af2b1 
possible fix for jjeising#13
@koenpunt koenpunt mentioned this issue Aug 17, 2016
Open
@jjeising
Copy link
Owner

Can you explain how this corresponds with #14?

@koenpunt
Copy link
Contributor Author

koenpunt commented Aug 17, 2016 •
edited
Loading

I opened the issue first, and then though I might be able to hook something up myself. But like I commented in #14, I think we're better of by also supporting non-default element, so that custom components can be folded as well.

@koenpunt koenpunt changed the title Feature request: Support folding Feature request: Support folding in JSX scope Nov 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jjeising @koenpunt