Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace relative image links with fully qualified paths in the docs #12

Open
markweitzel opened this issue Apr 30, 2013 · 3 comments
Open
Assignees
Labels

Comments

@markweitzel
Copy link

If you look at the NPM, all of the image links are broken. This is because NPM picks up the readme.md from github. However, because there are relative URLs in the docs, it tries to resolve everything at npm.org. Es no bueno.
https://npmjs.org/package/jive-sdk

@ghost ghost assigned markweitzel Apr 30, 2013
@5minpause
Copy link
Contributor

Is this still relevant? Could you point me to where at NPM things are breaking? If I visit https://www.npmjs.org/package/jive-sdk in the browser I cannot see any images as there are no images referenced inside of readme.md. What did I miss here?

@5minpause
Copy link
Contributor

I saw this #11. This issue seems to be a duplicate? I guess you could close it then. @markweitzel, @rachoac @ryanrutan

@matthewmccullough
Copy link
Contributor

This appears to have been fixed in two waves.

  1. The images were made absolute in 8e63a12
  2. The images were removed from the README.md in 6d8f998

Looks like we're good to go. Let's close this issue, @markweitzel and @ryanrutan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants