Reconnecting to XMPP server if MucClient failed to join the MUCs.

[veratiz]

#158

[jitsi-jenkins]

Hi, thanks for your contribution!
If you haven't already done so, could you please make sure you sign our CLA (https://jitsi.org/icla for individuals and https://jitsi.org/ccla for corporations)? We would unfortunately be unable to merge your patch unless we have that piece :(.

[bgrozev]

Why is this necessary? The XMPP connection was successful and the retry code will attempt to re-join the MUCs (without disconnecting)

[veratiz]

If xmppConnection successfully connected and logged in, but failed when join, re-join will never happen.
For example, when Prosody is rebooted and jicofo not yet reconnected, Jibri throws this exception:
2021-11-22 14:59:16.276 WARNING: [41] org.jitsi.xmpp.mucclient.MucClient.log() Failed to join the MUCs. org.jivesoftware.smack.XMPPException$XMPPErrorException: XMPP error reply received from jibribrewery@local/jibri-instanse-321207090: XMPPError: not-allowed - cancel [Room creation is restricted]

[damencho]

2021-11-22 14:59:16.276 WARNING: [41] org.jitsi.xmpp.mucclient.MucClient.log() Failed to join the MUCs. org.jivesoftware.smack.XMPPException$XMPPErrorException: XMPP error reply received from jibribrewery@local/jibri-instanse-321207090: XMPPError: not-allowed - cancel [Room creation is restricted]

This is jibri trying to create the brewery room before jicofo. There is no way for synchronizing when jicofo and jibri will do the attempt. To mitigate that problem you can put the jibri user to be admin and it will not see the error and will be allowed to create the room.