Merge pull request #22 from jchen86/check-on-startup

Perform initial check on startup

package.json

@@ -29,6 +29,9 @@
   },
   "jest": {
     "transform": {},
-    "testEnvironment": "jest-environment-node"
+    "testEnvironment": "jest-environment-node",
+    "restoreMocks": true,
+    "clearMocks": true,
+    "resetMocks": true
   }
 }

src/main.js

@@ -3,6 +3,7 @@ import { SMSNotifier } from './notifiers/index.js';
 import { config } from './config.js';
 import { BeaconAPIClient } from './beacon-api-client.js';
 import { validatorBalanceReducedAlert, validatorStatusChangedAlert } from './alerts/index.js';
+import { logger } from './logger.js';
 
 const smsNotifer = new SMSNotifier(config.sms)
 const beaconApiClient = new BeaconAPIClient(config.beaconAPIs);
@@ -11,4 +12,7 @@ const validatorPollingService = new ValidatorPollingService(beaconApiClient);
 validatorPollingService.addValidators(config.pubkeys);
 validatorPollingService.addListener(validatorBalanceReducedAlert(smsNotifer, config.alerts.validatorBalanceReduced));
 validatorPollingService.addListener(validatorStatusChangedAlert(smsNotifer));
-validatorPollingService.start();
+validatorPollingService.start()
+  .catch((err) => {
+    logger.error(`Error polling validators from Beacon API ${config.beaconAPIs}: `, err);
+  });

src/validator-polling-service.js

@@ -58,7 +58,8 @@ class ValidatorPollingService {
     }
   }
 
-  start() {
+  async start() {
+    await this.#pollValidators();
     setInterval(this.#pollValidators.bind(this), this.#pollingIntervalSeconds * 1000);
     logger.info(`Started polling validators every ${this.#pollingIntervalSeconds} seconds.`)
   }

test/validator-polling-service.test.js

@@ -14,17 +14,23 @@ describe('ValidatorPollingService', () => {
     beaconApiClient = new BeaconAPIClient('http://localhost:5052');
     svc = new ValidatorPollingService(beaconApiClient);
     jest.spyOn(BeaconAPIClient.prototype, 'getGenesisTime').mockImplementation(() => Promise.resolve());
+    jest.clearAllTimers();
   });
 
   it('should allow adding listener functions', () => {
     svc.addListener(() => 'I hear you!')
   });
 
-  it('should poll beaconApiClient every epoch', async () => {
+  it('should poll beaconApiClient on startup', async () => {
     const getValidatorsMock = jest.spyOn(BeaconAPIClient.prototype, 'getValidators').mockImplementation(() => Promise.resolve({ data: [] }));
+    await svc.start();
+    expect(getValidatorsMock).toHaveBeenCalledTimes(2);
+  });
 
-    svc.start();
-    expect(getValidatorsMock).not.toBeCalled();
+  it('should poll beaconApiClient every epoch', async () => {
+    const getValidatorsMock = jest.spyOn(BeaconAPIClient.prototype, 'getValidators').mockImplementation(() => Promise.resolve({ data: [] }));
+    await svc.start();
+    getValidatorsMock.mockClear();
 
     jest.advanceTimersByTime(SECONDS_PER_EPOCH * 1000);
     await flushPromises();