Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI fuzzing #433

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

johanbrandhorst
Copy link
Contributor

Fixes #432

Verified

This commit was signed with the committer’s verified signature.
pluma4345 Alan Plum @ArangoDB
Fixes jhump#432
@jhump
Copy link
Owner

jhump commented Oct 27, 2021

@johanbrandhorst, neat! Do I need to do anything with repo config for this to work? Where would I see the checks? Should they show up above, like alongside the "Circle CI" checks?

@johanbrandhorst
Copy link
Contributor Author

They show up in the CI checks like the circleCI jobs. I'm surprised this PR hasn't triggered one tbh, do you need to enable github actions on the repository? You can see what happened on the grpc-gateway PR: grpc-ecosystem/grpc-gateway#2405 (it created a Fuzzing job on the PR).

Re: #432 (comment), if the parser is already fuzzed continuously, then the value of this PR diminishes. It might be able to find crashers in new code sooner, but it also means every CI run takes 600 seconds to finish. Up to you what you want to do :).

@WillAbides
Copy link
Contributor

I'm surprised this PR hasn't triggered one

I think this hasn't triggered because PRs from people other than the owner don't trigger actions in order to prevent people from running malicious code through pull requests. It's documented here: https://docs.github.com/en/actions/managing-workflow-runs/approving-workflow-runs-from-public-forks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run fuzzing in CI
3 participants