You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The text was updated successfully, but these errors were encountered:
bufdev
changed the title
Set up automated test to compare protoc and protoparae output for src/google/protobuf/unittest.*proto?
Set up automated test to compare protoc and protoparse output for src/google/protobuf/unittest.*proto?
Apr 8, 2020
I can do this if you want.
What I'm thinking:
unittest.*proto
files from https://github.com/protocolbuffers/protobuf/tree/master/src/google/protobuf on an automated basis, either directly in a Golang test, or via a bash script.FileDescriptorSet
for each withprotoc
.FileDescriptorSet
for each with protoparse.proto.Equal
.We likely will have to exclude
SourceCodeInfo
for this type of automated test, but even without that, it's useful.Also would recommend doing this for googleapis.
Both #307 and #308 were discovered by effectively doing this manually.
Note there's some prior art, I can adapt https://github.com/bufbuild/buf/blob/c75b6195beced011672dbffd4a0a11d004ccbca4/internal/buf/bufbuild/builder_test.go for this purpose (this does it all in Golang).
The text was updated successfully, but these errors were encountered: