Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: JoyCaption as captioner #263

Open
StableLlama opened this issue Aug 15, 2024 · 9 comments
Open

Feature request: JoyCaption as captioner #263

StableLlama opened this issue Aug 15, 2024 · 9 comments

Comments

@StableLlama
Copy link

As seen at https://huggingface.co/spaces/fancyfeast/joy-caption-pre-alpha it is a model with superb captioning skills. It output was nearly creating the test image in Flux again.
So it would be great when it could be used as a taggui autocaptioner.

The implementation could be copied from the spaces as linked above.

@StableLlama
Copy link
Author

It seems this is the ordinary meta-llama/Meta-Llama-3.1-8B with the LoRA https://huggingface.co/spaces/fancyfeast/joy-caption-pre-alpha/blob/main/wpkklhc6/image_adapter.pt on top

@StableLlama
Copy link
Author

There's a fork of taggui that includes it now: https://github.com/doloreshaze337/taggui

@ArmadstheDoom
Copy link

There's a fork of taggui that includes it now: https://github.com/doloreshaze337/taggui

This doesn't actually seem to work? Following the instructions on that fork, it simply doesn't recognize the existence of the joycaption folder or the included imageadpter.pt. I have no idea why it doesn't, but it doesn't. Doesn't matter if you use the release or a git pull version, neither recognize the existence of it, so right now you can't use joycaption. Which sucks, because it's essentially required for tagging things for FLUX.

@StableLlama
Copy link
Author

This doesn't actually seem to work?

When it's not working you should open up an issue there and not here.

@ArmadstheDoom
Copy link

This doesn't actually seem to work?

When it's not working you should open up an issue there and not here.

The reason I put it here is because this is a feature request, and I didn't want them to go 'well there's a fork so no need to add it to the main branch.' I think that this is something that should be added to the main branch support since it drastically improves tagging for FLUX models.

@jhc13
Copy link
Owner

jhc13 commented Aug 30, 2024

I'll look into adding it as soon as I have time (I'm not sure when that will be).

@jhc13 jhc13 pinned this issue Aug 30, 2024
@ArmadstheDoom
Copy link

I'll look into adding it as soon as I have time (I'm not sure when that will be).

Glad to hear! Obviously, when you do it for free, one can't demand it be immediate. But I'm glad to hear it'll be added. Take your time though!

@BenDes21
Copy link

BenDes21 commented Nov 7, 2024

I'll look into adding it as soon as I have time (I'm not sure when that will be).

Hello there! Any news for integrate the new version of joycaption into taggui ? https://huggingface.co/spaces/fancyfeast/joy-caption-alpha-one

@jhc13
Copy link
Owner

jhc13 commented Nov 7, 2024

Hello there! Any news for integrate the new version of joycaption into taggui ? https://huggingface.co/spaces/fancyfeast/joy-caption-alpha-one

There's actually a newer version.

It will probably be included in the next release, but I am currently too busy to work on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants