Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid trailing whitespace in kobo spans #174

Merged
merged 7 commits into from
Oct 13, 2024
Merged

Avoid trailing whitespace in kobo spans #174

merged 7 commits into from
Oct 13, 2024

Commits on Oct 5, 2024

  1. Avoid trailing whitespace in kobo spans 

    This seems like a small change but has huge implications for the way text is rendered with optimizeLegibilty and geometricPrecision.

Signed-off-by: Shiandow <[email protected]>
    @Shiandow
    Shiandow authored Oct 5, 2024
    Configuration menu
    Copy the full SHA
    4c88c17 View commit details
    Browse the repository at this point in the history

  2. Also stop sentence on last non-whitespace character before end of line. 

    Signed-off-by: Shiandow <[email protected]>
    @Shiandow
    Shiandow authored Oct 5, 2024
    Configuration menu
    Copy the full SHA
    4e1a432 View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2024

  1. Stop linter nagging

    @Shiandow
    Shiandow committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    452236e View commit details
    Browse the repository at this point in the history

  2. Put trailing/leading whitespace outside of spans

    @Shiandow
    Shiandow committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    78cd242 View commit details
    Browse the repository at this point in the history

  3. Attempt to fix tests 

    Some of these were just replicating the implementation, which
seemed less than useful. I've tried to test the important properties.

The PR#106 test needs to be weakened a bit but the weakened test should
still catch the bug.
    @Shiandow
    Shiandow committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    5147596 View commit details
    Browse the repository at this point in the history

  4. Fix name

    @Shiandow
    Shiandow committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    d46894f View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2024

  1. Attempt to pass tests 

    The githup_106 test is a bit odd, because I'm not sure what changed.

Whitespace should be identical though, even without the lstrip.
Which is easy enough to check.
    @Shiandow
    Shiandow committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    d63e6b4 View commit details
    Browse the repository at this point in the history