Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Nuget support #58

Merged
merged 18 commits into from
Sep 1, 2020
Merged

Add Nuget support #58

merged 18 commits into from
Sep 1, 2020

Conversation

RobiNino
Copy link
Contributor

No description provided.

@RobiNino RobiNino requested a review from yahavi August 27, 2020 08:29
@RobiNino RobiNino marked this pull request as draft August 27, 2020 08:30
yahavi
yahavi requested changes Aug 27, 2020
View reviewed changes
Copy link
Member

@yahavi yahavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also run npm run format

src/main/utils/nugetUtils.ts Outdated Show resolved Hide resolved
yahavi
yahavi requested changes Aug 30, 2020
View reviewed changes
src/test/tests/nugetUtils.test.ts Outdated Show resolved Hide resolved
src/test/tests/nugetUtils.test.ts Outdated Show resolved Hide resolved
@RobiNino RobiNino marked this pull request as ready for review September 1, 2020 16:02
yahavi
yahavi approved these changes Sep 1, 2020
View reviewed changes
Copy link
Member

@yahavi yahavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RobiNino RobiNino merged commit 671da7d into jfrog:master Sep 1, 2020
@RobiNino RobiNino deleted the nuget-support branch September 1, 2020 16:04
@yahavi yahavi linked an issue Sep 11, 2020 that may be closed by this pull request
Support for NuGet #56
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yahavi yahavi yahavi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for NuGet
2 participants
@RobiNino @yahavi