Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JFrog CLI Build - Upgrade go to v1.23.1 #2688

Merged
merged 3 commits into from
Sep 11, 2024

Conversation

eyalbe4
Copy link
Contributor

@eyalbe4 eyalbe4 commented Sep 9, 2024

Upgrade the go version used to build and release JFrog CLI to 1.23.1.

@eyalbe4 eyalbe4 requested a review from EyalDelarea September 9, 2024 03:36
@eyalbe4 eyalbe4 added improvement Automatically generated release notes safe to test Approve running integration tests on a pull request labels Sep 9, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Sep 9, 2024
@eyalbe4
Copy link
Contributor Author

eyalbe4 commented Sep 9, 2024

@EyalDelarea,
I believe that the Static Analysis / Go-Sec ubuntu-latest (pull_request) will pass after https://github.com/jfrog/.github/pull/4/files is mreged, so will you be able to review https://github.com/jfrog/.github/pull/4/files first?

Copy link
Contributor

@EyalDelarea EyalDelarea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
We can also update the GO version inside the REAME.md :)
And also don't forget to raise the GO version in https://github.com/jfrog/jfrog-ecosystem-integration-env

go.mod Show resolved Hide resolved
@eyalbe4 eyalbe4 added the safe to test Approve running integration tests on a pull request label Sep 11, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Sep 11, 2024
Copy link
Contributor

👍 Frogbot scanned this pull request and did not find any new security issues.


@eyalbe4 eyalbe4 merged commit 741dc7f into jfrog:dev Sep 11, 2024
63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Automatically generated release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants