Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace NettyDockerCmdExecFactory for OkHttpDockerCmdExecFactory #798

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Ru13en
Copy link

@Ru13en Ru13en commented Jul 17, 2024

Add support to npipe protocol for windows docker by using okHttp.
Fixes #797

  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.

Copy link

github-actions bot commented Jul 17, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@Ru13en
Copy link
Author

Ru13en commented Jul 17, 2024

I have read the CLA Document and I hereby sign the CLA

@Ru13en
Copy link
Author

Ru13en commented Jul 17, 2024

recheck

@eyalbe4
Copy link
Contributor

eyalbe4 commented Jul 18, 2024

@Ru13en,
For integrating Jenkins with the JFrog Platform, our recommendation is to avoid using the old Artifactory Jenkins Plugin, and use the newer JFrog Jenkins Plugin whenever it is possible. The older plugin, because of its design, introduces multiple issues, especially when it comes to the integration with docker. We will therefore refrain from making new investments in the Artifactory Jenkins Plugin.

@Ru13en
Copy link
Author

Ru13en commented Jul 18, 2024

Hi @eyalbe4 , thank you for the info. I will give it a try then :). BR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add npipe support for build-info-extractor-docker
2 participants