Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to jackson-databind 2.17.0 #110

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Upgrade to jackson-databind 2.17.0 #110

wants to merge 1 commit into from

Conversation

veita
Copy link

@veita veita commented Mar 23, 2024

Fixes #109

  • All tests passed. If this feature is not already covered by the tests, I added new
    tests.

Fixes jfrog#109

Signed-off-by: Alexander Veit <[email protected]>
Copy link

github-actions bot commented Mar 23, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@eyalbe4 eyalbe4 self-requested a review March 23, 2024 07:27
@eyalbe4 eyalbe4 added the safe to test Approve running tests on a pull request label Mar 23, 2024
@github-actions github-actions bot removed the safe to test Approve running tests on a pull request label Mar 23, 2024
@veita
Copy link
Author

veita commented Mar 23, 2024

I have read the CLA Document and I hereby sign the CLA

@veita
Copy link
Author

veita commented Mar 24, 2024

This issue causes jeremylong/DependencyCheck#6542.

@eyalbe4
Copy link

eyalbe4 commented Mar 25, 2024

@veita,
As the above failing tests show, this dependency upgrade causes some versions of Gradle versions to fail.
We need to come up with an alternative solution, since merging this PR will most probably break many pipelines out there.
image

@veita
Copy link
Author

veita commented Mar 25, 2024

Sure that the reason for the failure is Jackson version 2.17.0?

Unsupported class file major version 61 points to Java 17. And the class files in https://repo1.maven.org/maven2/com/fasterxml/jackson/core/jackson-databind/2.17.0/jackson-databind-2.17.0.jar all have version 52.0 (Java 1.8).

@eyalbe4
Copy link

eyalbe4 commented Mar 25, 2024

I believe so @veita.
Take a look at the screenshot I attached above. You'll see the jackson package name as part of the error message.

@veita
Copy link
Author

veita commented Mar 25, 2024

I see Eyal and you're probably right. But I don't understand how the error could relate to Java class file major version 61 when the class files in jackson-databind-2.17.0.jar from Maven Central have version 52.0.

Could it be that the jackson-databind-2.17.0.jar in the test is not the original from Maven Central but something built with Java 17?

@aikebah
Copy link

aikebah commented Apr 7, 2024

@veita @eyalbe4 It's due to forward-incompatible behaviour of Gradle with respect to multi-release jars in its instrumentation attempts for plugins. See gradle/gradle#27156 for all the detail.

@eyalbe4 eyalbe4 removed their request for review July 15, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Artifactory plugin pulls in outdated Jackson version
3 participants