Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Angular 8 support #46

Closed
GMaxera opened this issue Jun 8, 2019 · 6 comments · Fixed by #47
Closed

Angular 8 support #46

GMaxera opened this issue Jun 8, 2019 · 6 comments · Fixed by #47

Comments

@GMaxera
Copy link

GMaxera commented Jun 8, 2019

I'd like to update to Angular 8 my project but there is a dependencies conflict that would requires an update by this package:

Package "ngx-malihu-scrollbar" has an incompatible peer dependency to "zone.js" (requires "^0.8.26", would install "0.9.1").
@jfcere
Copy link
Owner

jfcere commented Jun 8, 2019

Hi @GMaxera,

Sure, I am going to update the package this weekend... i'll keep your posted!

@jfcere jfcere mentioned this issue Jun 9, 2019
Merged
@jfcere jfcere closed this as completed in #47 Jun 9, 2019
@jfcere
Copy link
Owner

jfcere commented Jun 9, 2019 •
edited
Loading

Library has been updated to Angular 8, please update ngx-malihu-scrollbar to v8.0.0

@GMaxera
Copy link
Author

GMaxera commented Jun 9, 2019

Thank you ! It worked

@aaron170
Copy link

aaron170 commented Sep 4, 2019

Hello.

Can you please help me about this.?
I am also implementing in my Angular 8 project but nothing seems to work.
I have updated the plugin to v8.0.0. Still nothing happens.
Can you prepare a Demo for it. It would be helpful.

Thanks

@jfcere
Copy link
Owner

jfcere commented Sep 4, 2019 •
edited
Loading

Hi @aaron170,

You can take a look at the StackBlitz example or clone the repository and look at the demo folder in the repository.

If you're still having problems to set up the plugin and you have a repository you want me to check for you I can do it.

@aaron170
Copy link

aaron170 commented Sep 4, 2019

Hi Jean.

Thanks for the reply.

But still facing the issue.
I have created a Demo for it. https://stackblitz.com/edit/angular-with-malihu-scrollbar

Please see where I am going wrong.
Also I am getting error in Terminal like

error

Thanks for your help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update Angular 8 jfcere/ngx-malihu-scrollbar
3 participants
@GMaxera @jfcere @aaron170