feat(设备-详细信息-运行状态-详情)增加极差值统计规则 #478
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhou-hao
reviewed
Mar 12, 2024
| @@ -205,7 +207,10 @@ public Flux<Map<String, Object>> aggregation(String[] index, AggregationQueryPar | |||
| ) | |||
| ) | |||
| .flatMap(restClient::searchForPage) | |||
| .flatMapMany(this::parseResult) | |||
| .flatMapMany(row -> this.parseResult(row, aggregationQueryParam | |||
| }; | ||
| }, | ||
|
|
||
| DIFFERENCE("极差值") { |
| } | ||
| switch (agg) { | ||
| case DIFFERENCE: | ||
| BigDecimal max = (!Double.isInfinite(parsedStats.getMax()) ? BigDecimal.valueOf(parsedStats.getMax()) : BigDecimal.ZERO); |
There was a problem hiding this comment.
处理null的情况, max或者min为Infinite时，应该返回 null才对？(表示没有数据)。而0在某的场景下可能存在特殊意义。
| @@ -25,7 +25,8 @@ public enum Aggregation implements EnumDict<String> { | |||
|
|
|||
| //去重计数 | |||
| DISTINCT_COUNT(flux -> flux.distinct().count(),0), | |||
| NONE(numberFlux -> Reactors.ALWAYS_ZERO, 0); | |||
| NONE(numberFlux -> Reactors.ALWAYS_ZERO, 0), | |||
| DIFFERENCE(numberFlux -> MathFlux.sumDouble(numberFlux, Number::doubleValue), 0); | |||
There was a problem hiding this comment.
RANGE ? 默认值应该为0，且 sumDouble应该不符合需求？
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.