Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: snapshots don't work in dual package esm+cjs Typescript repo (ts-jest), even with "module": "CommonJS" #14723

Closed
darkbasic opened this issue Nov 27, 2023 · 7 comments

Comments

@darkbasic
Copy link

Version

v30.0.0-alpha.2

Steps to reproduce

  1. Clone https://github.com/darkbasic/jest-esm-repro
  2. yarn install
  3. yarn test

Expected behavior

A snapshot should be generated and eventually written to disk (with -u).

Actual behavior

Tests pass despite snapshots should be generated.

Additional context

I've tried jest 29 as well.

Environment

System:
    OS: Linux 6.6 Arch Linux
    CPU: (16) x64 AMD Ryzen 9 PRO 7940HS w/ Radeon 780M Graphics
  Binaries:
    Node: 20.10.0 - /run/user/1000/fnm_multishells/1050532_1701077373135/bin/node
    Yarn: 3.7.0 - /run/user/1000/fnm_multishells/1050532_1701077373135/bin/yarn
    npm: 10.2.3 - /run/user/1000/fnm_multishells/1050532_1701077373135/bin/npm
  npmPackages:
    jest: workspace:* => 30.0.0-alpha.2
@darkbasic
Copy link
Author

I'm not sure if #12014 is needed or not.
At least with "module": "CommonJS" it shouldn't be needed I guess.
I've rebased it against latest master: #14722

Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 30 days.

@github-actions github-actions bot added the Stale label Dec 27, 2023
@SimenB
Copy link
Member

SimenB commented Dec 28, 2023

Can you provide a reproduction without ts-jest? E.g. using the built-in babel-jest to strip TS types

@github-actions github-actions bot removed the Stale label Dec 28, 2023
Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 30 days.

@github-actions github-actions bot added the Stale label Jan 27, 2024
Copy link

This issue was closed because it has been stalled for 30 days with no activity. Please open a new issue if the issue is still relevant, linking to this one.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Feb 26, 2024
Copy link

This issue was closed because it has been stalled for 30 days with no activity. Please open a new issue if the issue is still relevant, linking to this one.

Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants