Skip to content
This repository has been archived by the owner on Jul 17, 2019. It is now read-only.

Pass $ext, $payload, and $contentType into generateHawkRequest from signRequest #1

Open
alxmrtn opened this issue Mar 28, 2014 · 2 comments

Comments

@alxmrtn
Copy link

alxmrtn commented Mar 28, 2014

generateHawkRequest() accepts 8 parameters with the last 3 being $ext, $payload and $contentType. signRequest() currently does not pass these 3 values into generateHawkRequest()

@jeskew
Copy link
Owner

jeskew commented Mar 29, 2014

signRequest() will be called directly by Guzzle and isn't really a userland function. Would it make sense to instead pass a $parsePayload directive into the constructor that would tell $signRequest to get those values from the request?

@jeskew
Copy link
Owner

jeskew commented Jul 1, 2014

Would this be fixed by #3 ?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants