Removing record with Sequel nested_attributes and Forme subform

[jeremyevans]

Google Group Post: https://groups.google.com/g/ruby-forme/c/8ucxgwvzMNM
Google Group Date: Tue, 22 Aug 2017 09:37:26 -0700
Google Group Sender: [email protected]

I naively thought this would work:

<% f.subform :some_association do %>
<%== f.input :_delete %>
<% end %>

Which complained about "_delete" being an invalid field. Looking at the
source, passing an explicit type made the following code work:

<% f.subform :some_association do %>
<%== f.input :_delete, type: :checkbox, no_hidden: true, value: true %>
<% end %>

Would it make sense for Forme (or Sequel through forme_input?) allow a
nicer short-hand implementation where the first implementation would work?

Thanks,

Adam

[jeremyevans]

Google Group Date: Tue, 22 Aug 2017 13:57:41 -0700
Google Group Sender: [email protected]

On Tuesday, August 22, 2017 at 4:33:35 PM UTC-4, Jeremy Evans wrote:

I don't think I'd like to see f.input :_delete as an API, as it is
inconsistent with the rest of the API, and many applications would handle
deletes differently (such as using separate buttons for them). I'm not
sure there is a good API that will work for all applications, so I think
the explicit approach you are using in the second implementation is
probably best as the default. You can add a
Sequel::Plugins::Forme::SequelForm#delete_checkbox method if you want to
dry up code that uses it.

I'm guessing you didn't intend this, but a _delete value that is true by
default for all associated objects seems dangerous. :)

With a bit more investigating, only the type option was required to get the
results I wanted, so it's much simpler now.

<%== f.input :_delete, type: :checkbox %>

Thanks for the feedback.

Adam