Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent L1/L2 names between EvoLinear and EvoTrees #21

Closed
ParadaCarleton opened this issue Oct 14, 2023 · 1 comment
Closed

Consistent L1/L2 names between EvoLinear and EvoTrees #21

ParadaCarleton opened this issue Oct 14, 2023 · 1 comment

Comments

@ParadaCarleton
Copy link

In EvoTrees, the L1/L2 regularizations are called gamma and lambda, respectively; would it be better to have consistent names for these between the two packages?

@jeremiedb
Copy link
Owner

Arguments naming have emerged from different considerations. Notably, EvoTrees got inspired by existing libraries naming practices (XGBoost), while I approached EvoLinear more as a clean slate. The interpretation of the gamma is also different as it can also be interprated as a tree pruning argument. I prefer not to bring changes to these names unless it comes with some material changes to their logic, justifying adpotions of new names. Otherwise, I prefer applying some L1 to API changes and not bring changes only for the sake of naming.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants