Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvement for isRevExcluded method. For matching on commit message #1516

Closed
wants to merge 1 commit into from
Closed

Improvement for isRevExcluded method. For matching on commit message #1516

wants to merge 1 commit into from

Conversation

gruaig
Copy link

@gruaig gruaig commented Oct 19, 2023

This improved version adds more logging, handles potential null values, and uses the find() method for matching. This should make the method more robust

This improved version adds more logging, handles potential null value…
ea44132 
…s, and uses the find() method for matching. This should make the method more robust.
@gruaig gruaig requested a review from a team as a code owner October 19, 2023 15:12
@gruaig
Copy link
Author

gruaig commented Oct 19, 2023 •
edited
Loading

All checks passed @MarkEWaite

@MarkEWaite
Copy link
Contributor

MarkEWaite commented Oct 21, 2023 •
edited
Loading

@gruaig thanks for the pull request. Could you remove the source code reformatting that has been done in the pull request? The contributing guide says:

Code formatting in the git plugin varies between files. Try to maintain reasonable consistency with the existing files where feasible. Please don’t perform wholesale reformatting of a file without discussing with the current maintainers.

There are many pull requests open for the git plugin and reformatting causes unnecessary conflicts with other pull requests.

When I'm ready to reformat the git plugin source code, it will be done with spotless:apply as provided by the parent pom. However, before that type of reformat, I need to be certain that the pending pull requests can all be adapted to it.

@MarkEWaite
Copy link
Contributor

@gruaig are you unwilling to correct the formatting? If so, then I'll close this pull request.

@MarkEWaite MarkEWaite closed this Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gruaig @MarkEWaite