Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add preview images for jdk21 #492

Merged
merged 2 commits into from
Sep 8, 2023
Merged

Add preview images for jdk21 #492

merged 2 commits into from
Sep 8, 2023

Conversation

nbr23
Copy link
Contributor

@nbr23 nbr23 commented Sep 7, 2023

Add jdk21 preview images

This is something that's been discussed here #587 in an effort to have alpine based arm64 images for the inbound agent.

Testing done

Built locally

Submitter checklist

@nbr23 nbr23 requested a review from a team as a code owner September 7, 2023 19:26
@gounthar
Copy link
Contributor

gounthar commented Sep 8, 2023

That's quite an impressive first contribution! Congratulations!

Copy link
Contributor

@dduportal dduportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is a nice first contribution! Thanks!

I understand that adding 2 new Dockerfiles is related to the way we "retrieve" the JDK on the existing one, which is currently incompatible with JDK21 as Temurin does NOT provide the Docker images with ea JDK21.

=> It is fine to keep this and we'll "merge" the JDK21 Dockerfiles with the existing ones either by changing the default JDK retrieval method (cc @gounthar as I remember you tried this kind of changes in jenkinsci/docker as an experimen t a few months earlier) to use the ZIP installed, OR by waiting for the images publications.

@dduportal dduportal merged commit d496703 into jenkinsci:master Sep 8, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants