Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker-agent windowsservercore-ltsc2019 images use a windowsservercore-1809 as base image #475

Closed
lemeurherve opened this issue Jul 31, 2023 · 5 comments · Fixed by #459
Closed
Assignees

Comments

@lemeurherve
Copy link
Member

Jenkins and plugins versions report

ci.jenkins.io

What Operating System are you using (both controller, and any agents involved in the problem)?

N/A

Reproduction steps

Before the recent refactoring there was

FROM eclipse-temurin:"${JAVA_VERSION}"-jdk-windowsservercore-1809

(It's still the case, the refactoring hasn't changed any thing in the artifacts generated)

Expected Results

docker-agent windowsservercore-ltsc2019 images use a windowsservercore-ltsc2019 as base image.

Actual Results

docker-agent windowsservercore-ltsc2019 images use a windowsservercore-1809 as base image.

Anything else?

No response

@lemeurherve lemeurherve self-assigned this Jul 31, 2023
@lemeurherve lemeurherve changed the title docker-agent windowsservercore-ltsc2019 images use a windowsservercore-1809 as base image instead of -ltsc2019 docker-agent windowsservercore-ltsc2019 images use a windowsservercore-1809 as base image Jul 31, 2023
@lemeurherve
Copy link
Member Author

It appears that like Eclipse, Microsoft didn't publish any powershell:windowsservercore-ltsc2019 image 🤦

$ docker pull mcr.microsoft.com/powershell:windowsservercore-1809
windowsservercore-1809: Pulling from powershell
4612f6d0b889: Pulling fs layer 
4dcc9a9b9e68: Pulling fs layer 
3cb7c01d4088: Download complete 
22cd36988ec7: Waiting 
e3624bb03373: Waiting 
5727bb89134c: Waiting 
c55c6355862a: Waiting 
ea08e765d0e8: Waiting 
$  docker pull mcr.microsoft.com/powershell:windowsservercore-ltsc2019
Error response from daemon: manifest for mcr.microsoft.com/powershell:windowsservercore-ltsc2019 not found: manifest unknown: manifest tagged by "windowsservercore-ltsc2019" is not found

Closing this issue.

@lemeurherve lemeurherve closed this as not planned Won't fix, can't repro, duplicate, stale Jul 31, 2023
@lemeurherve
Copy link
Member Author

lemeurherve commented Jul 31, 2023

As I'm working on #349 in #459 it appears to me there are no powershell:nanoserver-ltsc2019 or powershell:windowsservercore-ltsc2019, only 1809 ones.

Thus we don't currently have a "proper" docker-agent windowsservercore-ltsc2019, it's based on a windowsservercore-1809 image.

@timja @slide @jenkinsci/team-docker-packaging WDYT about switching the base images from powershell:nanoserver-1809 and powershell:windowsservercore-1809 to mcr.microsoft.com/windows/nanoserver:ltsc2019 and mcr.microsoft.com/windows/servercore:ltsc2019 (both available) so we could get "proper" ltsc2019 images alongside the 1809 ones?

FROM mcr.microsoft.com/powershell:nanoserver-"${WINDOWS_VERSION_TAG}"

FROM mcr.microsoft.com/powershell:windowsservercore-"${WINDOWS_VERSION_TAG}"

https://mcr.microsoft.com/v2/windows/servercore/tags/list
https://mcr.microsoft.com/v2/windows/nanoserver/tags/list

@lemeurherve lemeurherve reopened this Jul 31, 2023
@slide
Copy link
Member

slide commented Jul 31, 2023

If Microsoft is not supporting an image for it, we probably shouldn't support it either, but I'm fine if someone wants to put in the work to get it working.

@NotMyFault
Copy link
Member

Sounds good to me

@dduportal-cloudbees
Copy link

Someone who just has been bitten by this: https://community.jenkins.io/t/updating-powershell-7-version-included-with-jenkins-agent-docker-image/8691 (their Powershell version depends on the 1809 image as far as I can tell while they expect a version for LTS2019)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants