Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unbounded memory usage in generating traces from stage data #429

Closed
msbit01 opened this issue Jun 3, 2024 · 2 comments
Closed

Unbounded memory usage in generating traces from stage data #429

msbit01 opened this issue Jun 3, 2024 · 2 comments
Assignees
Labels
kind/bug Bug related issue

Comments

@msbit01
Copy link
Contributor

msbit01 commented Jun 3, 2024

Describe the bug
When creating StageData objects for trace generation, there is no limit on the number of objects created, which can result in unbounded memory consumption.

Label the issue properly.

  • Add severity/ label.
  • Add documentation label if this issue is related to documentation changes.

To Reproduce
Steps to reproduce the behavior:

  1. Create a pipeline that produces thousands of stages.
  2. Run the pipeline.
  3. Check heap usage data, e.g. by hitting the /monitoring endpoint if using the monitoring plugin.
  4. Observe large number of StageData objects.

Expected behavior
The code already throws out stage data when the size of the associated json object exceeds 5000 characters, so we should be short-circuiting StageData creation as well.

Screenshots
If applicable, add screenshots to help explain your problem.

Environment and Versions (please complete the following information):
I'm using Jenkins 6.0.3 and believe the issue was introduced in 6.0.0, in this change #381

Additional context
Add any other context about the problem here.

@nikita-tkachenko-datadog
Copy link
Collaborator

The new release v7.1.0 includes the fix.

@tsmsbit
Copy link

tsmsbit commented Jun 4, 2024

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Bug related issue
Projects
None yet
Development

No branches or pull requests

3 participants