From cd538404e46151c7fc3020b613dafdedd68e6076 Mon Sep 17 00:00:00 2001
From: rsandell <rsandell@cloudbees.com>
Date: Mon, 23 Oct 2023 17:27:29 +0200
Subject: [PATCH 1/2] Prepare for prototype removal

---
 .../credentials/CredentialsStoreAction/newDomain.jelly    | 6 +++---
 src/main/resources/lib/credentials/dialog.js              | 2 +-
 src/main/resources/lib/credentials/select/select.js       | 8 ++++----
 3 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/src/main/resources/com/cloudbees/plugins/credentials/CredentialsStoreAction/newDomain.jelly b/src/main/resources/com/cloudbees/plugins/credentials/CredentialsStoreAction/newDomain.jelly
index c34c314dc..a19a2cfd5 100644
--- a/src/main/resources/com/cloudbees/plugins/credentials/CredentialsStoreAction/newDomain.jelly
+++ b/src/main/resources/com/cloudbees/plugins/credentials/CredentialsStoreAction/newDomain.jelly
@@ -33,7 +33,7 @@
       <f:form action="createDomain" method="POST" name="newDomain">
         <f:entry title="${%Domain Name}" help="/plugin/credentials/help/domain/name.html">
           <f:textbox id="name" field="name" onchange="updateOk(this.form)" onkeyup="updateOk(this.form)"/>
-          <script>$('name').focus();</script>
+          <script>document.getElementById('name').focus();</script>
         </f:entry>
         <f:entry title="${%Description}" help="/plugin/credentials/help/domain/description.html">
           <f:textarea name="description"/>
@@ -47,11 +47,11 @@
         </f:bottomButtonBar>
       </f:form>
       <script><![CDATA[
-        var okButton = makeButton($('ok'), null);
+        var okButton = makeButton(document.getElementById('ok'), null);
 
         function updateOk(form) {
           function state() {
-            return ($('name').value.length === 0);
+            return (document.getElementById('name').value.length === 0);
           }
 
           okButton.set('disabled', state(), false);
diff --git a/src/main/resources/lib/credentials/dialog.js b/src/main/resources/lib/credentials/dialog.js
index 56a18a39f..87b2419e9 100644
--- a/src/main/resources/lib/credentials/dialog.js
+++ b/src/main/resources/lib/credentials/dialog.js
@@ -3,5 +3,5 @@ Behaviour.specify("#credentials-add-submit", 'credentials-dialog-add', 0, functi
 });
 
 Behaviour.specify("#credentials-add-abort", 'credentials-dialog-abort', 0, function (e) {
-    e.onclick = (_) => window.credentials.dialog.hide();
+    e.onclick = (_) => window.credentials.dialog.style.display = "none";
 });
\ No newline at end of file
diff --git a/src/main/resources/lib/credentials/select/select.js b/src/main/resources/lib/credentials/select/select.js
index 74af1724e..13a9357c1 100644
--- a/src/main/resources/lib/credentials/select/select.js
+++ b/src/main/resources/lib/credentials/select/select.js
@@ -37,7 +37,7 @@ window.credentials.init = function () {
             visible: false,
             keylisteners: [
               new YAHOO.util.KeyListener(document, {keys:27}, {
-                fn:(function() {window.credentials.dialog.hide();}),
+                fn:(function() {window.credentials.dialog.style.display = "none";}),
                 scope:document,
                 correctScope:false
               })
@@ -62,7 +62,7 @@ window.credentials.add = function (e) {
                 window.credentials.dialog.cfg.setProperty("width", r.width * 3 / 4 + "px");
                 window.credentials.dialog.cfg.setProperty("height", r.height * 3 / 4 + "px");
                 window.credentials.dialog.center();
-                window.credentials.dialog.show();
+                window.credentials.dialog.style.display = "";
             });
         }
     });
@@ -165,7 +165,7 @@ window.credentials.addSubmit = function (e) {
             responseDialog.cfg.setProperty("width", r.width * 3 / 4 + "px");
             responseDialog.cfg.setProperty("height", r.height * 3 / 4 + "px");
             responseDialog.center();
-            responseDialog.show();
+            responseDialog.style.display = "";
         }
         window.setTimeout(function () {// otherwise Firefox will fail to leave the "connecting" state
             document.getElementById(id).remove();
@@ -179,7 +179,7 @@ window.credentials.addSubmit = function (e) {
     } finally {
         f.target = null;
     }
-    window.credentials.dialog.hide();
+    window.credentials.dialog.style.display = "none";
     return false;
 };
 Behaviour.specify("BUTTON.credentials-add-menu", 'credentials-select', -99, function(e) {

From cabf86d9208a7609d67d0a0b15a84a9dc3286805 Mon Sep 17 00:00:00 2001
From: rsandell <rsandell@cloudbees.com>
Date: Wed, 25 Oct 2023 16:01:07 +0200
Subject: [PATCH 2/2] Revert select.js

---
 src/main/resources/lib/credentials/select/select.js | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/main/resources/lib/credentials/select/select.js b/src/main/resources/lib/credentials/select/select.js
index b7798ccec..a5f44aa2a 100644
--- a/src/main/resources/lib/credentials/select/select.js
+++ b/src/main/resources/lib/credentials/select/select.js
@@ -37,7 +37,7 @@ window.credentials.init = function () {
             visible: false,
             keylisteners: [
               new YAHOO.util.KeyListener(document, {keys:27}, {
-                fn:(function() {window.credentials.dialog.style.display = "none";}),
+                fn:(function() {window.credentials.dialog.hide();}),
                 scope:document,
                 correctScope:false
               })
@@ -62,7 +62,7 @@ window.credentials.add = function (e) {
                 window.credentials.dialog.cfg.setProperty("width", r.width * 3 / 4 + "px");
                 window.credentials.dialog.cfg.setProperty("height", r.height * 3 / 4 + "px");
                 window.credentials.dialog.center();
-                window.credentials.dialog.style.display = "";
+                window.credentials.dialog.show();
             });
         }
     });
@@ -141,7 +141,7 @@ window.credentials.addSubmit = function (_) {
                 console.error("Could not add credentials:", e);
             })
             .finally(() => {
-                window.credentials.dialog.style.display = "none";
+                window.credentials.dialog.hide();
             });
     }
 };