Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameterized Java version inconsistent with CD workflow #29

Closed
basil opened this issue May 7, 2024 · 2 comments · Fixed by #30
Closed

Parameterized Java version inconsistent with CD workflow #29

basil opened this issue May 7, 2024 · 2 comments · Fixed by #30

Comments

@basil
Copy link

basil commented May 7, 2024

In jenkins-infra/github-reusable-workflows#31 it was discussed whether to make the Java version a parameter or to just use a modern version as an internal implementation detail, with a decided preference for the latter. This repository's choice of a parameterized value is inconsistent with that decision.

@daniel-beck
Copy link
Contributor

Would #30 address this request? Or is the request to remove the ability to specify the version entirely?

@basil
Copy link
Author

basil commented May 14, 2024

I meant inconsistent on an API level. Inconsisency on an implementation level is far less important.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants