[infra.ci.jenkins.io] Azure VM agent init script not in sync with Puppet code

[dduportal]

Service(s)

infra.ci.jenkins.io

Summary

The initScript code used to initialized an Azure VM agent on infra.ci.jenkins.io is not in sync with the Puppet code

• infra.ci:
  • Linux agents: https://github.com/jenkins-infra/kubernetes-management/blob/7f68d6474b095ddc530d0a6613d31d2c63fe01e8/config/jenkins_infra.ci.jenkins.io.yaml#L258-L284
  • Windows agents: https://github.com/jenkins-infra/kubernetes-management/blob/7f68d6474b095ddc530d0a6613d31d2c63fe01e8/config/jenkins_infra.ci.jenkins.io.yaml#L322C19-L331
• Puppet code:
  • Linux agents: https://github.com/jenkins-infra/jenkins-infra/blob/0bf38f2a49644610e452c5d35d775970877e901c/dist/profile/templates/jenkinscontroller/casc/clouds.yaml.erb#L76-L166
  • Windows agents: https://github.com/jenkins-infra/jenkins-infra/blob/0bf38f2a49644610e452c5d35d775970877e901c/dist/profile/templates/jenkinscontroller/casc/clouds.yaml.erb#L18-L72

The main consequence is that agents are not set up properly on infra.ci as the datadog agent often fails to start up. We discovered this unwanted behavior while working on #4124

Reproduction steps

No response

[dduportal]

Update: the initial PR worked well (jenkins-infra/kubernetes-management#5584).

Now @jayfranco999 will do a second PR to generalize the change and we're done with this issue 👍

[dduportal]

Finished with success in jenkins-infra/kubernetes-management#5597