-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Java 17 update for CD workflow #30
Comments
I think this can be easily solved by adding an optional input for the java version? |
Looks it was considered already #5 Perhaps a version v2 of workflows should be sufficient |
Opened #31 with a default JAVA_MAJOR_VERSION input set to "11" by default that can easily be set to "17" by plugin maintainers until we switch this default value to "17" when controllers will require JDK17. This should circumvent the need for a v2. WDYT? |
As suggested by @jglick in #31 (comment), I changed the scope of my pull request to directly update Java to 17:
I'll post that in the original jenkinsci-dev mailing list thread at https://groups.google.com/g/jenkinsci-dev/c/11P2B9s67tw/m/buquLnLeAwAJ for additional reviews and see if there is any objection. |
What feature do you want to see added?
Java version used for CD must be updated when controllers require minimum Java 17 version.
https://github.com/jenkins-infra/github-reusable-workflows/blob/main/.github/workflows/maven-cd.yml#L55
Upstream changes
No response
The text was updated successfully, but these errors were encountered: