From 3b1e7cfc6d65c42b1212bfcd624c260025d8426c Mon Sep 17 00:00:00 2001
From: "jenkins-infra-updatecli[bot]"
 <101213878+jenkins-infra-updatecli[bot]@users.noreply.github.com>
Date: Thu, 22 Aug 2024 17:23:06 +0200
Subject: [PATCH] Extend Azure AD Application password validity on
 `trusted.ci.jenkins.io` (current end date: 2024-09-02T00:00:00Z) (#801)

This PR generates a new Azure AD application password with a new end
date for the `trusted.ci.jenkins.io` controller (to allow spawning Azure
VM agents).

Once this PR is merged and deployed with success by Terraform (on
infra.ci.jenkins.io),
you can retrieve the new password value from the Terraform state with
`terraform show -json`
then searching for the new password in `values.value` of the
`module.controller_service_principal_end_date` section (do NOT save it
anywhere!)
and (manually) update the trusted.ci.jenkins.io credential named
`azure-jenkins-sponsorship-credentials` through the Jenkins UI.

Finally, verify both Azure Credential and Azure VM clouds by checking
that a click on the "Verify <...>" buttons returns a success,
then restart the controller to ensure that the old credential is not
kept in cache.


---



<Actions>
<action
id="ab61385ee3fa09084aa4842b5a9d9c2ca4dc882f77fac205278e30fe8907f328">
<h3>Generate new end date for the trusted.ci.jenkins.io controller Azure
AD Application password</h3>
<details
id="4191ba5f46dbb754c1e7d30549ffcee986a6a05817c850ea79cf471743ba992d">
<summary>Update Terraform file `trusted.ci.jenkins.io.tf` with new
expiration date</summary>
<p>changes detected:&#xA;&#x9;path
&#34;module.controller_service_principal_end_date&#34; updated from
&#34;2024-09-02T00:00:00Z&#34; to &#34;2024-11-20T00:00:00Z&#34; in file
&#34;trusted.ci.jenkins.io.tf&#34;</p>
        </details>
<a
href="https://infra.ci.jenkins.io/job/updatecli/job/azure/job/main/387/">Jenkins
pipeline link</a>
    </action>
</Actions>

---

<table>
  <tr>
    <td width="77">
<img src="https://www.updatecli.io/images/updatecli.png" alt="Updatecli
logo" width="50" height="50">
    </td>
    <td>
      <p>
Created automatically by <a
href="https://www.updatecli.io/">Updatecli</a>
      </p>
      <details><summary>Options:</summary>
        <br />
<p>Most of Updatecli configuration is done via <a
href="https://www.updatecli.io/docs/prologue/quick-start/">its
manifest(s)</a>.</p>
        <ul>
<li>If you close this pull request, Updatecli will automatically reopen
it, the next time it runs.</li>
<li>If you close this pull request and delete the base branch, Updatecli
will automatically recreate it, erasing all previous commits made.</li>
        </ul>
        <p>
Feel free to report any issues at <a
href="https://github.com/updatecli/updatecli/issues">github.com/updatecli/updatecli</a>.<br
/>
If you find this tool useful, do not hesitate to star <a
href="https://github.com/updatecli/updatecli/stargazers">our GitHub
repository</a> as a sign of appreciation, and/or to tell us directly on
our <a
href="https://matrix.to/#/#Updatecli_community:gitter.im">chat</a>!
        </p>
      </details>
    </td>
  </tr>
</table>

Co-authored-by: Jenkins Infra Bot (updatecli) <60776566+jenkins-infra-bot@users.noreply.github.com>
---
 trusted.ci.jenkins.io.tf | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/trusted.ci.jenkins.io.tf b/trusted.ci.jenkins.io.tf
index 2dc3bdd7..5cc7d7e3 100644
--- a/trusted.ci.jenkins.io.tf
+++ b/trusted.ci.jenkins.io.tf
@@ -43,7 +43,7 @@ module "trusted_ci_jenkins_io" {
   controller_service_principal_ids = [
     data.azuread_service_principal.terraform_production.id,
   ]
-  controller_service_principal_end_date = "2024-09-02T00:00:00Z"
+  controller_service_principal_end_date = "2024-11-20T00:00:00Z"
   controller_packer_rg_ids = [
     azurerm_resource_group.packer_images["prod"].id
   ]