Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent space key behavior #4857

Open
felix920506 opened this issue Oct 8, 2023 · 4 comments · Fixed by #4864
Open

Inconsistent space key behavior #4857

felix920506 opened this issue Oct 8, 2023 · 4 comments · Fixed by #4864
Labels
bug Something isn't working confirmed The issue has been verified ui & ux This PR or issue mainly concerns UI & UX

Comments

@felix920506
Copy link
Member

felix920506 commented Oct 8, 2023

Describe The Bug
The behavior when hitting the space bar is inconsistent between video and music playback

Steps To Reproduce

  1. Start playing music
  2. Press space key

Expected Behavior
Music should pause, then start playing again upon the space key being pressed again.

Actual Behavior
After starting playback, the space key will do one of 2 things:

  1. If I had clicked anything prior to pressing the space key, hitting the space key will act as if said button has been clicked again.
    examples:

    • If I hit space right after starting an album, the space key will act as if I clicked play on the album again and start the album over from the start
    • If I click on next track then hit space, it will skip to the next track.
  2. If I had not clicked anything on that page, hitting the space key will scroll down.

System (please complete the following information):

  • Platform: MacOS
  • Browser: JMP, Chrome, Firefox
  • Jellyfin Version: 10.8.11

Additional Context
During video playback, hitting the space key always pauses / unpauses playback regardless of what I had clicked prior to pressing the space key.

@felix920506
Copy link
Member Author

Hi, I have just tested this on #4864 and it appears to have not completely solved the issue:

  • If I press space in the fullscreen view after clicking on a button, the space key will act as if said button has been clicked again
  • If I don't enter the fullscreen view, pressing the space key still exhibits the exact same behavior.

@thornbill thornbill reopened this Oct 20, 2023
@jellyfin-bot

This comment has been minimized.

@jellyfin-bot jellyfin-bot added the stale No activity for an extended length of time label Feb 18, 2024
@felix920506
Copy link
Member Author

still a bug

@jellyfin-bot jellyfin-bot removed the stale No activity for an extended length of time label Feb 19, 2024
@solidsnake1298
Copy link
Member

Confirmed still present in the latest unstable docker image.

@felix920506 felix920506 added confirmed The issue has been verified ui & ux This PR or issue mainly concerns UI & UX labels Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working confirmed The issue has been verified ui & ux This PR or issue mainly concerns UI & UX
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants