Improvements and fixes tvdb sdk 4.7.9.1 + PR #112 #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… is wrong in some situations
BobSilent
force-pushed
the
improvements-tvdb-sdk-4.7.9.1
branch
from
2ec9964 to
2e9c25c
Compare
|
@crobibero sorry for the inconveniences, at least last commit needs to be pushed to master, if you want i can also separate the commit into an own PR, later the day. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
crobibero
approved these changes
Feb 29, 2024
BobSilent
force-pushed
the
improvements-tvdb-sdk-4.7.9.1
branch
from
2e9c25c to
500b855
Compare
|
fixed the open review |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There where some open code reviews in #113 which are fixed
leading to store a default
int == 0as TvdbId instead of ignoring these values.i refactored the TvdbId Handling into an extension class
and an overlap with #113 and #112 which leads to compile issues.