Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adaptions for 10.9 #114

Closed
wants to merge 13 commits into from
Closed

Adaptions for 10.9 #114

wants to merge 13 commits into from

Conversation

BobSilent
Copy link
Contributor

This PR contains the required changes for updating to jellyfin 10.9.

Currently no nuget packages are available - or at least i did not found any for 10.9 therefore this will not build.
But who wants to build can disabled these nuget references

    <PackageReference Include="Jellyfin.Data" Version="10.*-*" />
    <PackageReference Include="Jellyfin.Controller" Version="10.*-*" />
    <PackageReference Include="Jellyfin.Common" Version="10.*-*" />
    <PackageReference Include="Jellyfin.Model" Version="10.*-*" />

and add directly references to these dlls from a 10.9 installation:

  • Jellyfin.Data.dll
  • Jellyfin.Extensions.dll
  • MediaBrowser.Common.dll
  • MediaBrowser.Controller.dll
  • MediaBrowser.Model.dll

Shadowghost and others added 5 commits February 19, 2024 01:42
@Shadowghost
Merge pull request jellyfin#110 from BobSilent/fix-tvdb-v4-migration
0fae371 
Fixes for tvdb v4 migration
@BobSilent
Fix duplicate entries Missing and not Missing (jellyfin#106)
60b3018 
* Fix TVDB 4 episode equals season number

* Fix TVDB4 Translation selection

* Fix TVDB4 Api filter for season, for episode

* Fix possible null exception

* Add logging

* add delete of missing episodes in library scan

* improve logging, review comment.

* Fix NullRefException, although Property is not marked as Nullable

* Simplify code

* Like TvdbSeriesProvider preserve OriginalTitle also for Episodes

* structured logging
@scampower3
Update to Tvdb sdk 4.7.9.1 (jellyfin#113)
a143e0c
@BobSilent
Make Tvdb Client usage more resilient and robust (jellyfin#112)
dbe5456 
* catch JsonException

* refactor duplicate code and catch JsonException
@BobSilent
remove some usage of GetValueOrDefault as it returns 0 for int? which…
150c9f3 
… is wrong in some situations
@scampower3
Copy link
Member

scampower3 commented Feb 29, 2024 •
edited
Loading

Hey, serviceCollection.AddHostedService<TvdbMissingEpisodeProvider>(); needs to be added in RegisterServices in TvdbPluginServiceRegistrator.cs for the TvdbMissingEpisodeProvider to ever run

@BobSilent BobSilent force-pushed the support-jellyfin-10.9 branch from a5c58d1 to e792a31 Compare February 29, 2024 21:47
@crobibero crobibero changed the base branch from master to unstable March 8, 2024 00:31
@crobibero
Copy link
Member

@BobSilent when you have a moment can you please fix merge conflicts?

We are trying something new 👀

@BobSilent
Copy link
Contributor Author

@crobibero: forgot to mention - done!

@crobibero crobibero deleted the branch jellyfin:unstable March 26, 2024 00:27
@crobibero crobibero closed this Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scampower3 scampower3 scampower3 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@BobSilent @scampower3 @crobibero @Shadowghost