Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some sort of basic sanity testing for PRs #12

Open
jeffwidman opened this issue Jan 21, 2022 · 2 comments
Open

Add some sort of basic sanity testing for PRs #12

jeffwidman opened this issue Jan 21, 2022 · 2 comments

Comments

@jeffwidman
Copy link
Owner

jeffwidman commented Jan 21, 2022

As demonstrated in #11, we need some sort of basic sanity checking for PRs.

Ideally we test each PR against all versions of python it claims to support. That way, if there's a packaging issue in an older setuptools, pip, python etc we catch it.

I think all we need to do is wire up something that starts a cassandra docker image and verifies that cqlsh can connect to it. That would have flagged all the issues I've hit in this repo so far.

Ideally it would both install cqlsh as a module within another super simple python program and install it as an executable.

Test matrix should probably be supported Python versions (tox is probably handy) * OS (Linux/Windows). May also want to run against multiple Cassandra versions, although I tend to think that's the domain of the Cassandra project as here we really only control the packaging aspect.

But for starters, even getting one flow working would be great.

@bschoening
Copy link
Collaborator

It's fairly simple to setup Travis and its free for open source.

@jeffwidman
Copy link
Owner Author

Last I heard, that's no longer true now that Travis was bought by PE: https://news.ycombinator.com/item?id=25338983

Azure pipelines, Github Actions, or CircleCI are common choices. Given the simplicity of what we need, GitHub Actions is probably both simple while still powerful enough to do what we want.

Just need to wire it up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants