Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support gemoji 4.0.0 #85

Open
casperdcl opened this issue Nov 25, 2022 · 3 comments
Open

support gemoji 4.0.0 #85

casperdcl opened this issue Nov 25, 2022 · 3 comments

Comments

@casperdcl
Copy link

casperdcl commented Nov 25, 2022 •
edited
Loading

vis. jekyll/jemoji#122

See https://github.com/github/gemoji/releases/tag/v4.0.0.pre0 for breaking changes.
@ashmaroli
Copy link

For anyone planning on submitting a pull request: you need not drop support for Gemoji v3 for backwards compatibility. Relaxing the constraint to allow Gemoji v4 should suffice.

@casperdcl casperdcl changed the title bump gemoji to 4.0.0 support gemoji 4.0.0 Nov 25, 2022
@casperdcl
Copy link
Author

yes, >=3, <5 is probably safest :)

@Freed-Wu
Copy link

Any progress about this issue? @jeffreytse

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@casperdcl @ashmaroli @Freed-Wu