Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invisible comments inside popup menus #10

Open
veselyn opened this issue Dec 28, 2022 · 2 comments
Open

Invisible comments inside popup menus #10

veselyn opened this issue Dec 28, 2022 · 2 comments

Comments

@veselyn
Copy link

veselyn commented Dec 28, 2022

The PMenu highlight group has the same background color as the foreground color of Comment, therefore, comments are "invisible" inside popup menus. This is the case for both of the background options (light or dark).

Would it make sense to swap the Comment highlights between light and dark mode here: https://github.com/jeffkreeftmeijer/vim-dim/blob/main/colors/dim.vim#L26-L54?


Light mode

image

Dark mode

image

Actual content inside the popup menu

image

@jeffkreeftmeijer
Copy link
Owner

Could you show how that would look? I think I’d rather change the background colors of the pmenus than changing the comment colors, but I could be wrong.

@veselyn
Copy link
Author

veselyn commented Mar 19, 2023

This is how the comments look like in a popup menu with the colors swapped (with background set to dark):

image

However, outside of the popup menus, the comments blend in with other highlights:

image
image

Perhaps it makes more sense to swap the colors of the pmenus instead so the comments can remain with lower contrast.

This is how it looks like for me with them swapped (top picture is with background set to dark):
image
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants