Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is 8 colors terminal supported by dim? #1

Open
shunlir opened this issue Sep 18, 2019 · 2 comments
Open

Is 8 colors terminal supported by dim? #1

shunlir opened this issue Sep 18, 2019 · 2 comments

Comments

@shunlir
Copy link

shunlir commented Sep 18, 2019

The color scheme is using 16 color number, taking a highlight group from the source:

" Highlight search matches in black, with a yellow background
highlight Search         ctermfg=0    ctermbg=11

the background color is not showing correctly for 8 colors terminal:
image
After changing 11 to 3*, it looks good:
image

@shunlir
Copy link
Author

shunlir commented Sep 19, 2019

I did a few investigation, dim only works when t_Co>=16.
Do you know is there any working color fallback method supported by VIM can be used?
I tried colors in :h cterm-color, but no one is perfect:

  • using color name has good fall back from 16 to 8 colors, e.g. LightYellow means 3 when t_Co==8, 11 when t_Co==16, but for 256 color terminal, the color number is 229
  • using 3* doesn't change to 11 when t_Co is 16 or 256, seems a bug of VIM? (this works for neovim)

@jeffkreeftmeijer
Copy link
Owner

Hey @shunlir, sorry for taking so long to get back to you on this. I’m not sure what the issue is here, but are you still having this problem? I’d merge a 8-color setting if it looks okay, but I’m afraid I don’t have time to look into that myself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants