Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback #6

Open
flpvsk opened this issue Feb 22, 2016 · 0 comments
Open

Feedback #6

flpvsk opened this issue Feb 22, 2016 · 0 comments

Comments

@flpvsk
Copy link

flpvsk commented Feb 22, 2016

Hey Dinarte,

I went through your code and launched the app locally. Result looks good as well
as the code. Although the app is straightforward, you haven't overcomplicated
it, that's good.

Couple of things:

  • You're using bower together with npm. You need to add bower install step
    to your instructions. Or, better, use only npm, get rid of this extra
    dependency.

  • Consider using some form of CSS methodology. I'd suggest BEM, but there're
    many more. And ideally use only one class per element.

    https://css-tricks.com/bem-101/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant