You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I went through your code and launched the app locally. Result looks good as well
as the code. Although the app is straightforward, you haven't overcomplicated
it, that's good.
Couple of things:
You're using bower together with npm. You need to add bower install step
to your instructions. Or, better, use only npm, get rid of this extra
dependency.
Consider using some form of CSS methodology. I'd suggest BEM, but there're
many more. And ideally use only one class per element.
Hey Dinarte,
I went through your code and launched the app locally. Result looks good as well
as the code. Although the app is straightforward, you haven't overcomplicated
it, that's good.
Couple of things:
You're using
bower
together withnpm
. You need to addbower install
stepto your instructions. Or, better, use only
npm
, get rid of this extradependency.
Consider using some form of CSS methodology. I'd suggest BEM, but there're
many more. And ideally use only one class per element.
https://css-tricks.com/bem-101/
The text was updated successfully, but these errors were encountered: