Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] decimal separator in the JWSACruncher #136

Open
AQLT opened this issue Oct 27, 2023 · 2 comments
Open

[FR] decimal separator in the JWSACruncher #136

AQLT opened this issue Oct 27, 2023 · 2 comments
Assignees

Comments

@AQLT
Copy link
Contributor

AQLT commented Oct 27, 2023

It could be good to be able to change the decimal separator in the JWSACruncher to avoid a system dependency. This is linked to jdemetra/jwsacruncher#13.

@Immurb Immurb self-assigned this Jun 13, 2024
@JanGerhardt
Copy link

Changing the decimal separator is not implemented yet but technically possible. In the current release, the locale defines the decimal separator.
To make it changeable, one could replace using the locale with using the settings from the cruncher’s params file (or its default settings) in the formatter classes. This would also affect some functionalities of JD+ which contain creating (csv) output files.
If some users made use of changing the locale for some reason (that is doable, e.g. with a plug-in), those functionalities would possible create a different output file than expected.
Therefore, it needs to be discussed when to use the locale and when to use an individual specification before the code is altered.
Besides, we found that the number of decimals ndecs from the params file is not applied correctly: In the DoubleFormatter class “9” is hard coded as the max number of decimals, so both the locale and the params settings have no influence.

@AQLT
Copy link
Contributor Author

AQLT commented Jun 20, 2024

Currently, in my opinion, the problem is also that the decimal separator changes the column separator. If your local is a comma, then the exported file when you choose "CSV" or "CSV matrix" is not anymore a CSV file.
Moreover, being able to fix/change the decimal separator would improve the reproducibility of software results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants