Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compile instructions to README/Makefile #8

Open
DivineDominion opened this issue Jun 7, 2022 · 3 comments
Open

Add compile instructions to README/Makefile #8

DivineDominion opened this issue Jun 7, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@DivineDominion
Copy link
Contributor

I'm on a M1 (arch arm64) Mac and cannot load the x86_64 .dylib. I am not versed in Rust development, so I tried to re-build the .dylib by running cargo build --release from the core/ subdirectory.

Possible steps for a Makefile:

cd core; cargo build --release
cp core/target/release/libflx_rs_core.dylib ./bin/
@DivineDominion
Copy link
Contributor Author

Making a universal binary, i.e. arm64 and x86_64 is a WIP it seems: rust-lang/cargo#8875

This repo or https://github.com/jcs090218/flx-rs could maybe use GitHub actions instead to prepare a universal binary and attach that to releases. Until then, compiling locally is the only option for users, so a makefile step would be the cheapest solution

@jcs090218
Copy link
Member

Thanks for the information! ❤️

This repo already uses GitHub actions to build binary files, see .github/workflows/build.yml. Of course this isn't universal, but we could wait until Rust has made those changes. :)

@jcs090218 jcs090218 added the enhancement New feature or request label Jun 8, 2022
@jcs090218
Copy link
Member

@DivineDominion After #11, you should able to read flx-rs.aarch64-apple-darwin.dylib file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants