Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase test coverage for MP Metrics & MP FT integration testing #212

Open
istraka opened this issue Mar 5, 2020 · 3 comments
Open

Increase test coverage for MP Metrics & MP FT integration testing #212

istraka opened this issue Mar 5, 2020 · 3 comments
Labels
good first issue Good for newcomers

Comments

@istraka
Copy link
Member

istraka commented Mar 5, 2020 •
edited
Loading

Current test coverage for MP Metrics & MP FT integration has shown two issues:

Per discussion with @Ladicek MP Metrics for @Asynchronous may be wrong (both with Future and CompletionStage return type).
@istraka istraka added the good first issue Good for newcomers label Mar 5, 2020
@mnovak1
Copy link
Member

mnovak1 commented Mar 5, 2020

fyi @spriadka @tterem

@Ladicek
Copy link

Ladicek commented Mar 5, 2020

The 2 linked bugs were from the old implementation, which indeed had a weird way of collecting metrics. The new implementation should be much better in that regard, so I'm much more confident in metrics being correct now. Tests can't hurt for sure, of course :-)

@mnovak1
Copy link
Member

mnovak1 commented Mar 5, 2020

@spriadka @tterem could you check whether the issue is still present, please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Ladicek @mnovak1 @istraka