Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

org.jboss.eap.qe.ts.common.docker.Docker prints directly to System.out #195

Open
honza-kasik opened this issue Jan 22, 2020 · 3 comments
Open
Assignees

Comments

@honza-kasik
Copy link
Member

We should use and configure jboss-logging for this instead.

@mnovak1
Copy link
Member

mnovak1 commented Jan 22, 2020

I remember we've discussed in scope of: #21 and decided to use simple System.out for docker. However I was proffering to use proper logging ;-)

@honza-kasik
Copy link
Member Author

honza-kasik commented Jan 23, 2020

Ah, thanks - I missed that. The bare minimum I would like to tho is make the PrintStream which will be used configurable for now. WDYT @mnovak1 ?
EDIT: I would also like to remove the ANSI escape codes, so the possible transition to logger in future is more seamless.

@mnovak1
Copy link
Member

mnovak1 commented Jan 23, 2020

I would prefer more proper logging. But let's have it just for docker as I don't see any other module which would have strong need for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants