Fix unnecessary conditional logic in cache implementations

jberryman · Dec 20, 2019 · 3f848a5 · 3f848a5
1 parent c766881
commit 3f848a5
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 10 deletions.
diff --git a/server/src-lib/Hasura/Cache/Bounded.hs b/server/src-lib/Hasura/Cache/Bounded.hs
@@ -159,11 +159,9 @@ getLocal (BoundedCache handles) = do
 
   (i, _) <- myThreadId >>= threadCapability
 
-  -- The number of capability could be dynamically changed.
-  -- So, let's check the upper boundary of the vector
-  let lim = V.length handles
-      j | i < lim   = i
-        | otherwise = i `mod` lim
+  -- The number of capabilities can grow dynamically so make sure we wrap
+  -- around when indexing.
+  let j = i `mod` V.length handles
 
   return $ handles V.! j
 

diff --git a/server/src-lib/Hasura/Cache/Unbounded.hs b/server/src-lib/Hasura/Cache/Unbounded.hs
@@ -69,11 +69,9 @@ getLocal (UnboundedCache handles) = do
 
   (i, _) <- myThreadId >>= threadCapability
 
-  -- The number of capability could be dynamically changed.
-  -- So, let's check the upper boundary of the vector
-  let lim = V.length handles
-      j | i < lim   = i
-        | otherwise = i `mod` lim
+  -- The number of capabilities can grow dynamically so make sure we wrap
+  -- around when indexing.
+  let j = i `mod` V.length handles
 
   return $ handles V.! j