We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clean-duplicate-history
Problem Statement Performance of the clean-duplicate-history function could be optimized.
Describe the solution you'd like I want to suggest a simple improvement. There's nested count operation the result of which is only using in a log statement at verbosity level 2: https://github.com/jazzband/django-simple-history/blob/master/simple_history/management/commands/clean_duplicate_history.py#L69
count
I'd like to run count only if we actually log the result. Otherwise we should use exists.
exists
Describe alternatives you've considered None. I think this is a pretty simple change
The text was updated successfully, but these errors were encountered:
Successfully merging a pull request may close this issue.
Problem Statement
Performance of the
clean-duplicate-history
function could be optimized.Describe the solution you'd like
I want to suggest a simple improvement. There's nested
count
operation the result of which is only using in a log statement at verbosity level 2: https://github.com/jazzband/django-simple-history/blob/master/simple_history/management/commands/clean_duplicate_history.py#L69I'd like to run
count
only if we actually log the result. Otherwise we should useexists
.Describe alternatives you've considered
None. I think this is a pretty simple change
The text was updated successfully, but these errors were encountered: