Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SocketMemcachedTests seems to be redundant #220

Open
moisesguimaraes opened this issue Jan 17, 2020 · 0 comments
Open

SocketMemcachedTests seems to be redundant #220

moisesguimaraes opened this issue Jan 17, 2020 · 0 comments

Comments

@moisesguimaraes
Copy link
Contributor

The test SocketMemcachedTests seems redundant in the current codebase.

class SocketMemcachedTests(test_simple_functions.MemcachedTests):
"""
Same tests as above, just make sure it works with sockets.
"""
def setUp(self):
self.server = '/tmp/memcached.sock'
self.client = bmemcached.Client(self.server, 'user', 'password')

It extends test_simple_functions.MemcachedTests, but this one is also a socket test:

class MemcachedTests(unittest.TestCase):
def setUp(self):
self.server = '/tmp/memcached.sock'
self.client = bmemcached.Client(self.server, 'user', 'password')
self.reset()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant