Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only request WRITE_EXTERNAL_STORAGE when needed #14

Open
graingert opened this issue Jan 19, 2016 · 2 comments
Open

only request WRITE_EXTERNAL_STORAGE when needed #14

graingert opened this issue Jan 19, 2016 · 2 comments
Assignees

Comments

@graingert
Copy link

eg when the "save in "Downloads"" options is chosen in the "Do you want to keep the update?" dialog, trigger the request for permission.

@javiersantos
Copy link
Owner

That would be interesting. Right now I am not using the permissions feature of Android 6.0 because it will require the WRITE_EXTERNAL_STORAGE permission at the first startup. Moreover, if you decline the permission, the app won't work.

Beta Updater downloads the updates on the "Downloads" directory. When the dialog is shown, if the user keeps the update, it just do nothing. But, if the user decides to delete the update, the file is removed from the "Downloads" directory.

I think that should be a directory where the app could write the update (maybe Context.getApplicationInfo().dataDir) without requesting the permission, and the file will be moved to the "Downloads" directory if the user decides to keep the update (and request for the permission).

@graingert
Copy link
Author

I think that should be a directory where the app could write the update (maybe Context.getApplicationInfo().dataDir) without requesting the permission, and the file will be moved to the "Downloads" directory if the user decides to keep the update (and request for the permission).

This

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants