Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

using AuthenticationMethod.EXTERNAL and an AccessProvider results in NullPointerException #177

Open
pdowler opened this issue May 28, 2020 · 0 comments

Comments

@pdowler
Copy link

pdowler commented May 28, 2020

The url argument to ExternalAuthenticationCommandImpl constructor is null and passed to superclass, resulting in an attempt to create an HttpGet that throws the NullPointerException.

Simple fix: ExternalAuthenticationCommandImpl can override HttpGet createRequest(String url) and return a null. This is sufficient to allow a custom AccessProvider to work.

I have tested that this fix works, but there is no ExternalAuthenticationCommandImplTest to modify.

Ready to create a pull request with the simple fix if this looks OK or if review happens with the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant