Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document which exceptions are thrown during send/receive #120

Open
bitc opened this issue Jul 1, 2016 · 1 comment
Open

Document which exceptions are thrown during send/receive #120

bitc opened this issue Jul 1, 2016 · 1 comment

Comments

@bitc
Copy link

bitc commented Jul 1, 2016

The haddocks for receiveDataMessage say that this function can throw ConnectionException under various conditions.

But it is not clear if there are any other exceptions that can occur. The following issues seem to hint that it is also possible for lower level socket exceptions or SSL exceptions to bubble up: #69 #75 . We need proper documentation that tells us a complete list of which exceptions we can expect. (It is not totally clear to me from looking through the source code)

Same goes for the send* family of functions.

Thank you

@jberryman
Copy link

I don't agree we need a "complete list of exceptions" that might be thrown (we have an exception system in the first place because this isn't really an attainable goal...), but would like some clarity on whether we should expect socket errors

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants