Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add filename option to define custom filename 😉 #318

Closed
wants to merge 2 commits into from

Conversation

voronianski
Copy link

This changes are related to #317

@keithamus
Copy link
Collaborator

Seems a little excessive to have 2 CLI options to set 1 thing. Surely you're either going to set a custom title or not right?

@voronianski
Copy link
Author

@keithamus I think that both options are necessary as they are not reliable on each other.

@keithamus
Copy link
Collaborator

Hmm, I'd like @jashkenas to pick this one up. I'm still not sold on adding 2 new CLI options, personally.

@voronianski
Copy link
Author

@keithamus @jashkenas I'll provide some use cases:

  • option --filename from CLI will work fine only for one file at once
  • option --useTitle provides flexibility for such CLI use scenario when you need to generate docs for several files with custom output filenames at once

@jashkenas
Copy link
Owner

Using the title as a filename isn't nice, or desirable. My Fancy Title.html is a gross file name.

--filename, as you point out, only works for one file at a time, making it a lousy command-line option.

Let's not.

@voronianski
Copy link
Author

@jashkenas that's sad :(

I could agree that --useTitle could be very subjective for my own use case but at least such option as --filename should be present here.

@Mouvedia
Copy link

I need --filename.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants