Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Backbone anything that has URI encoded characters (spaces and quotation marks) in the fragment triggers loadUrl twice in the navigate function #4188

Closed
tsangjustin opened this issue Mar 21, 2018 · 1 comment

Comments

@tsangjustin
Copy link

When I pass URI encoded characters such as spaces and quotation marks into the fragment navigate will decode the fragment and store that in this.fragment. When checkUrl is later on triggered it will detect that the fragment has changed even though it hasn't the encoded and decoded version of the fragment is compared and makes them not equal. This causes loadUrl to be triggered and load the encoded version of the fragment.

@tsangjustin tsangjustin changed the title Bug: Backbone anything that has URI encoded characters (spaces and quotation marks) in the fragment triggers Bug: Backbone anything that has URI encoded characters (spaces and quotation marks) in the fragment triggers loadUrl twice in the navigate function Mar 21, 2018
@jarstelfox
Copy link

jarstelfox commented Apr 12, 2018

@tsangjustin,

Which browser are you using?

Exabeam's comment on #4132 explains what is happening in depth. gwynjudd on #4175 mentioned the url encoding changed in chrome 63 (Released Dec 2017), which lines up with the recent influx of comments on tickets:

This issue also may have existed in Firefox (due to comments on the mentioned tickets), however, I have not tested at this time.

sjmiller85 wrote a workaround for this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants